Skip to content

more solution javascript basic added #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rabobahago
Copy link

@rabobahago rabobahago commented Jan 6, 2023

I love this repo and wanted to contribute to it in order to make this project one shot for every JavaScript Engineer looking to start with an algorithm. I have been solving algorithms for the past year and this repo has helped. Hope this contribution will even make the repo better.

Checklist before requesting a review

  • I have checked the guide for contributions.
  • I have added the description at the top of the solution file.
  • I have added a test file for the problem.
  • I have added an entry to the README file with a link to the new file.
  • I have run linter (npx eslint LeetcodeProblems LeetcodeProblemsTests) and unit tests (node Test.js) and they pass. More info.

Check the guide and this PR example.

@rabobahago rabobahago closed this Jan 7, 2023
@rabobahago rabobahago deleted the rabobranch branch January 7, 2023 07:27
@ignacio-chiazzo
Copy link
Owner

Hi! Thanks for contributing. I’m glad it helps.

I will be happy to review and merge solutions you find. Feel free to open PRs and tag me directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants